Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: NONREENTRANT and REENTRANT opcodes #8543

Merged
merged 11 commits into from
May 28, 2024
Merged

Add EIP: NONREENTRANT and REENTRANT opcodes #8543

merged 11 commits into from
May 28, 2024

Conversation

charles-cooper
Copy link
Contributor

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@charles-cooper charles-cooper requested a review from eth-bot as a code owner May 9, 2024 13:58
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels May 9, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented May 9, 2024 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label May 9, 2024
@charles-cooper charles-cooper mentioned this pull request May 9, 2024
Closed
pcaversaccio
pcaversaccio reviewed May 9, 2024
View reviewed changes
EIPS/nonreentrant.md Outdated Show resolved Hide resolved
EIPS/nonreentrant.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 9, 2024
@mouhand999 mouhand999 mentioned this pull request May 9, 2024
Open
abcoathup
abcoathup reviewed May 9, 2024
View reviewed changes
EIPS/nonreentrant.md Outdated Show resolved Hide resolved
abcoathup
abcoathup reviewed May 9, 2024
View reviewed changes
EIPS/nonreentrant.md Outdated Show resolved Hide resolved
@eth-bot eth-bot added the e-review Waiting on editor to review label May 10, 2024
@eth-bot eth-bot changed the title EIP for reentrancy protection opcodes Add EIP: NONREENTRANT and REENTRANT opcodes May 10, 2024
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels May 10, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 10, 2024
@github-actions GitHub Actions
Copy link

The commit ff8d5b2 (as a parent of 62d8607) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 10, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 10, 2024
@poojaranjan poojaranjan mentioned this pull request May 14, 2024
Closed
19 tasks
@Moser007 Moser007 mentioned this pull request May 27, 2024
Open
@poojaranjan poojaranjan mentioned this pull request May 28, 2024
Closed
13 tasks
g11tech
g11tech approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eth-bot eth-bot enabled auto-merge (squash) May 28, 2024 16:40
eth-bot
eth-bot approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit bdbb217 into ethereum:master May 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@pcaversaccio pcaversaccio pcaversaccio left review comments

@mouhand999 mouhand999 mouhand999 approved these changes

@eth-bot eth-bot eth-bot approved these changes

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@charles-cooper @eth-bot @pcaversaccio @abcoathup @g11tech @mouhand999